cncjs / cncjs / 3666

85%

push

travis-ci

Fix #581 - jog not working on Marlin (#583)

* Fix #581 - jog not working on Marlin

This RE works better for parsing Marlin temperature reports:
* It handles the "ok T:0" case that Marlin issues when it has no temperature probes
* It allows B@ and W fields to be optionally present after T:, T0:, and T1: blocks, instead of as alternatives to them.
* It recognizes all the test cases shown in the code commentary, whereas the original fails on most of them.
https://www.debuggex.com/?flavor=javascript is a really great way to visualize and test regular expressions!

See the trail in issue #581 for visualizations of the two regex's.

As an alternative to this complicated RE that tries to enumerate all possibilities, it might be better to just go for something simple like
/\s*T:[0-9\-]/

* chore: add test cases for Marlin controller

* fix(eslint): fix import errors

* refactor(Marlin): simplifies the regular expression that matches the temperature string

Co-authored-by: Cheton Wu <cheton@gmail.com>

611 of 915 branches covered (66.78%)

1 of 1 new or added line in 1 file covered. (100.0%)

1273 of 1503 relevant lines covered (84.7%)

481.74 hits per line