rytilahti / python-miio / 1550

74%

push

travis-ci

Add fan_speed_presets() for querying available fan speeds (#643)

* Add fan_speed_presets() for querying available fan speeds

This returns a dictionary {name, value} of the available fan speeds,
the main driver being the need to simplify homeassistant integrations for different devices.

For viomi vacuums this is currently straightforward and hard-coded, but we do special handling
for rockrobo devices (based on info() responses):

* If the query succeeds, newer firmware versions (3.5.7+) of v1 are handled as a special case,
  otherwise the new-style [100-105] mapping is returned.

* If the query fails, we fall back to rockrobo v1's percentage-based mapping.
  This happens, e.g., when the vacuum has no cloud connectivity.

Related to #523

Related downstream issues
https://github.com/home-assistant/core/pull/32821
https://github.com/home-assistant/core/issues/31268
https://github.com/home-assistant/core/issues/27268

* Fix method naming..

* small pre-merge cleanups

554 of 967 branches covered (57.29%)

Branch coverage included in aggregate %.

45 of 45 new or added lines in 2 files covered. (100.0%)

4037 of 5343 relevant lines covered (75.56%)

1.51 hits per line