derbyjs / racer / 897

69%

master: 74%

push

travis-ci

Fix deferred unload (see a320772a) when unfetching then synchronously subscribing

When a doc gets unfetched, #276 adds a Share Doc whenNothingPending listener to unload the doc later, instead of doing nothing, which was the cause of a memory leak introduced in #266.

However, Racer keeps reference counts itself for fetches and subscriptions, so an immediate subscribe on the same Racer doc does not affect the Share doc at all, which means the doc would still get unloaded, erroneously.

This fix instead retries the Racer _maybeUnloadDoc in that scenario, instead of doing an immediate unload. That guards against Racer getting new doc references while the Share Doc whenNotingPending is in progress.

776 of 1275 branches covered (60.86%)

Branch coverage included in aggregate %.

2291 of 3176 relevant lines covered (72.13%)

186.96 hits per line