eclipsesource / jsonforms / 2935

83%

push

travis-ci

Shallow compare schema and uischema props

Use shallow compare to determine schema and uischema prop changes
improving performance in almost all cases.

The 'areEqual' check is used to determine whether the previous set of
props is equal to the next set of props. Up until now lodash's deep
equal was used for the schema and uischema props. This would only be
beneficial if we changed the actual schema objects without changing
their content and the comparison would take less time than a rerender.
In practice we almost never change the schema and uischema objects
and when we do we usually also change their content. A deep equal is
therefore unnecessary and additionally harms performance for large
objects.

921 of 6441 branches covered (14.3%)

2 of 2 new or added lines in 1 file covered. (100.0%)

3367 of 3775 relevant lines covered (89.19%)

65.11 hits per line