ladybug-tools / ladybug / 784

92%

master: 91%

push

travis-ci

feat(sunpath): Refactor sunpath to use ladybug_geometry instead of plus

This commit switches the Ladybug sunpath to use ladybug_geometry to generate all of its graphics. This effectively allows the production of highly customized geometry using only Python.

This commit also adds a module for generating compass graphics, which are intended to be used by the sunpath as well as graphics like the wind rose that @saeranv is working on.

Lastly, I found and fixed quite a lot of bugs and made several enhancements to the sun path including:

* Time zones for a lot of EPW locations were being "autocorrected" to solar time. Notably, at least half of Chinese sunpaths did not have the right time zone from the EWP file. Instead of this, I made sure that a user-specified (or epw-specified) time zone always takes precedence but, if a user does not specify a time zone, it will default to the solar time zone based on the longitude.
* Fixed a math domain error that was occurring whenever someone requested solar vectors at precise solar noon.
* Fixed a math domain error that was occurring whenever the north or south pole was used as a location.
* Fixed a syntax bug in the calculation of atmospheric refraction. Essentially, multiple lines of code were not being included in the refraction factor calculation. I am guessing this is leftover because this Sunpath class was one of the first classes Mostapha tried to write with a 79 characters-per-line limit and the correct syntax for multi-line statements wasn't yet ingrained.
* Fixed the is_daylight_saving_hour method to correctly interpret the st_hour and end_hour of the analysis period as the time of the day when daylight saving starts/ends. Before, if a user had messed with these start and end hours, they would have gotten a sunpath jumping in and out of daylight saving every day.
* Fixed the application of daylight savings to move the clocks forward (it was incorrectly moving the clock backwards previously)
* Changed la... (continued)

356 of 356 new or added lines in 3 files covered. (100.0%)

6371 of 6930 relevant lines covered (91.93%)

1.83 hits per line