5224
0%
master: %

Ran 19 Mar 2020 11:30AM UTC

Jobs 7

Files 0

Run time –

Badge

Embed ▾

pending completion

Build # 5224

Build Type

push

travis-ci-com

Committed by

cathay4t

Commit Message

nm sriov: Properly return when device not exists

When interface does not exists, the `nm.sriov._has_sriov_capability()`
will raise:

```python
    def _has_sriov_capability(ifname):
        dev = device.get_device_by_name(ifname)
>       if nmclient.NM.DeviceCapabilities.SRIOV & dev.props.capabilities:
E       AttributeError: 'NoneType' object has no attribute 'props'
```

Fixed by add additional check on whether device is None.

Also fixed the integration test which incorrectly using eth0 which is
not test NIC, changed to eth1.

Signed-off-by: Gris Ge <fge@redhat.com>
Signed-off-by: Fernando Fernandez Mancera <ffmancera@riseup.net>

Run Details

Jobs

ID	Job ID	Ran
2	5224.2 (use_coveralls=true CONTAINER_IMAGE=docker.io/nmstate/centos8-nmstate-dev:nmstate-0.2 testflags="--test-type integ_slow --pytest-args='-x'")	19 Mar 2020 11:32AM UTC	Travis Job 5224.2
3	5224.3 (use_coveralls=true CONTAINER_IMAGE=docker.io/nmstate/centos8-nmstate-dev:nmstate-0.2 testflags="--test-type format")	19 Mar 2020 11:30AM UTC	Travis Job 5224.3
4	5224.4 (use_coveralls=true CONTAINER_IMAGE=docker.io/nmstate/centos8-nmstate-dev:nmstate-0.2 testflags="--test-type lint")	19 Mar 2020 11:32AM UTC	Travis Job 5224.4
5	5224.5 (use_coveralls=true CONTAINER_IMAGE=docker.io/nmstate/centos8-nmstate-dev:nmstate-0.2 testflags="--test-type unit_py36")	19 Mar 2020 11:32AM UTC	Travis Job 5224.5
6	5224.6 (use_coveralls=true CONTAINER_IMAGE=docker.io/nmstate/centos8-nmstate-dev:nmstate-0.2 testflags="--test-type integ --pytest-args='-x' --copr networkmanager/NetworkManager-1.22-git")	19 Mar 2020 11:41AM UTC	Travis Job 5224.6
7	5224.7 (use_coveralls=true CONTAINER_IMAGE=docker.io/nmstate/centos8-nmstate-dev:nmstate-0.2 testflags="--test-type integ --pytest-args='-x' --copr networkmanager/NetworkManager-master")	19 Mar 2020 11:42AM UTC	Travis Job 5224.7
8	5224.8 (use_coveralls=true testflags="--test-vdsm")	19 Mar 2020 11:46AM UTC	Travis Job 5224.8

Source Files on build 5224

Detailed source file information is not available for this build.

nmstate / nmstate / 5224
0%
master: %

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 5224

nmstate / nmstate / 5224 0% master: %

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 5224

nmstate / nmstate / 5224
0%
master: %

README BADGES
x