499
89%

Ran 13 Mar 2020 09:05PM CUT

Jobs 1

Files 56

Run time 16s

Badge

Embed ▾

pending completion

Build # 499

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

fix: add `shutdown()` to `Unleash` (#103)

This PR introduces a new `shutdown()` method to 2 interfaces, `Unleash` and `UnleashScheduledExecutor`

In order to properly shutdown a server that's running an Unleash client, all scheduled threads should be shutdown gracefully.

With the current implementation there is no clean way to shutdown the `UnleashScheduledExecutor`. If we're using the default implementation of `UnleashScheduledExecutorImpl`, all fields that would allow us to do so are either private, or are swallowed; The `ScheduledFuture` object returned from `setInterval` is not set to any field in the 2 constructors that call it, `UnleashMetricServiceImpl` and `FeatureToggleRepository`. Nor is the `ScheduledThreadPoolExecutor` exposed (it has a `shutdown()` method).

Our only option right now is to implement our own `UnleashScheduledExecutor`, pass it in as the config, and have a `close()` or `shutdown()` method on it. (we can't even use `UnleashScheduledExecutorImpl` because of the private fields.

The implementation gets the executor from the `config` instance and call `shutdown()` on it. That way, no matter which implementation of `UnleashScheduledExecutor` one would use, they can shut it down via the main interface.

Run Details

889 of 960 relevant lines covered (92.6%)

0.93 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	499.1	13 Mar 2020 09:05PM CUT	56	92.6	Travis Job 499.1

Source Files on build 499

Coverage	File	Lines	Relevant	Covered	Missed	Hits/Line
0.0	...in/java/no/finn/unleash/event/Log4JSubscriber.java	36	12	0	12	0.0
0.0	...no/finn/unleash/util/UnleashScheduledExecutor.java	16 + 4	1 + 1	0	1 + 1	0.0
20.0	src/main/java/no/finn/unleash/Unleash.java	39 + 2	5 + 1	1	4 + 1	1.0 - 1.0
66.67	...java/no/finn/unleash/strategy/UnknownStrategy.java	19	3	2	1	1.0 - 1.0
68.18	src/main/java/no/finn/unleash/Variant.java	63	22	15	7	1.0 - 1.0
82.35	...ava/no/finn/unleash/metric/ClientRegistration.java	68	17	14	3	1.0 - 1.0
83.33	src/main/java/no/finn/unleash/variant/Payload.java	36	12	10	2	1.0 - 1.0
83.33	...rc/main/java/no/finn/unleash/util/UnleashURLs.java	36	12	10	2	1.0 - 1.0
85.71	.../java/no/finn/unleash/strategy/ConstraintUtil.java	26	7	6	1	1.0 - 1.0
85.71	...inn/unleash/util/UnleashScheduledExecutorImpl.java	61 + 4	21 + 2	18 + 2	3	1.0 - 1.0

92.6
src/

Unleash / unleash-client-java / 499
89%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 499

Unleash / unleash-client-java / 499 89%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 499

Unleash / unleash-client-java / 499
89%

README BADGES
x