104
47%

Ran 11 Mar 2020 11:29PM UTC

Jobs 1

Files 9

Run time 2s

Badge

Embed ▾

pending completion

Build # 104

Build Type

push

travis-ci

Committed by

tgbugs

Commit Message

RepoPath.rmtree fixes for windows

RepoPath.commit hits a code path inside GitPython that makes a call to
git.cmd.Git._get_persistent_cmd which spawns processes that have their
working dir inside a repository, so if we try to rmtree the repository
windows gets unhappy and yells at us that some program is still using
the path. That someone is ofcourse our own subprocesses, so we pop off
the offending repo class and close it.

The two offending calls inside of commit are to repo.active_branch.is_valid()
the is_valid is the primary offender, not the active_branch, and
repo.git.stash is the other. There may be others, but this commit
should fix all of them. Appropriately, if you try to rmtree using a
different type of path then the error will still occure on windows as
it should since only RepoPath classes should be rmtreeing themselves
if there are active repo instances in a running python program.

Given that git.Repo is probably supposed to be used inside a context
manager and ours are not for performance/object duplication reasons,
it might be a good idea to see if there are some consistent points at
which it makes sense to pop repos off in general and close them.

Run Details

1148 of 2581 relevant lines covered (44.48%)

0.44 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
2	104.2 (PIPENV_VENV_IN_PROJECT=1 PIPENV_IGNORE_VIRTUALENVS=1)	11 Mar 2020 11:29PM UTC	0	44.48	Travis Job 104.2

Source Files on build 104

Detailed source file information is not available for this build.

tgbugs / augpathlib / 104
47%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 104

tgbugs / augpathlib / 104 47%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 104

tgbugs / augpathlib / 104
47%

README BADGES
x