kubevirt / hyperconverged-cluster-operator / 1943
69%
main: 76%

LAST BUILD BRANCH: recommended-cpu
DEFAULT BRANCH: main
Ran
Jobs 1
Files 1
Run time 1s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 68.854%. Remained the same
1943

push

travis-ci-com

web-flow 
[release-2.3] Emit a warning event on failed uninstall (#494)

* Emit a warning event on failed uninstall

Now Virt and CDI operators implements a validating
webhook that can prevent their CRs from being deleted
when we have existing VMs or DVs.
When the user will try to delete HCO CR, HCO will try
to delete Virt and CDI CRs and so it can fail there.
In that case, HCO CR is flagged for deletion and HCO
will periodically retry with an exponential
backoff mechanism.

Adding here the code to emit a warning event
to make it more evident to the user.

Adding an explicit delete request on KubeVirt
resource to check its status.

A better approach will be implemented in a future PR:
we are going to implement a validating webhook also here
that will try to delete virt and CDI resources in dry-run
mode and it will reject the deletion of HCO CR with a
clear error message if virt or cdi CRs cannot be deleted.

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>

* Avoid failing deletion on missing resources

Avoid failing the whole reconciliation loop on deletion
if just one tof the resources we are going to delete
is already missing.

Now Kubevirt and CDI defines a delete protection mechanism
so we can potentially get in status where we sucesfully
deleted Kubevirt CR while we have to loop only on CDI one
until we have pending DVs.
In that case, avoid failing the whole loop just because
we already deleted kubevirt CR in a previous run.

Signed-off-by: Simone Tiraboschi <stirabos@redhat.com>

Co-authored-by: Simone Tiraboschi <stirabos@redhat.com>

787 of 1143 relevant lines covered (68.85%)

3.22 hits per line

Jobs
ID Job ID Ran Files Coverage
1 1943.1 0
68.85
 Travis Job 1943.1
Source Files on build 1943
Detailed source file information is not available for this build.