release-engineering / alt-src / 66

84%

master: 85%

Pull #23

travis-ci

Fix broken handling of lockfile during cleanup [DELIVERY-8817]

Previously, if the staging was incomplete, alt-src script would remove
the whole work directory together with lock file. It may leading to
crash since the os.rmdir doesn't support removing non-emtpty dir and
removal of lock file may give another process a chance creating a lock
file at the same path.
This patch rename the lock file to <workdir>.lock and make it a sibling
of workdir, which means while removing the workdir, the lock won't be
removed. Also the method used to remove dir is changed to shutil.rmtree.

3 of 3 new or added lines in 1 file covered. (100.0%)

1227 of 1455 relevant lines covered (84.33%)

0.84 hits per line