go-sql-driver / mysql / 1837

83%

cron

travis-ci

Put zero filler into the SSL handshake packet. (#1066)

According to the linked documentation at
http://dev.mysql.com/doc/internals/en/connection-phase-packets.html#packet-Protocol::SSLRequest
SSLRequest packet should have zero filler similar to the regular handshake request,
but now the driver puts zeros only in the regular request. Luckily vanilla MySQL
doesn't rely on this zero filler and doesn't verify its presence, thus the driver worked
fine so far. But MySQL can change to rely on zeros at any point.

The problem was discovered while testing against a customized MySQL.

4 of 4 new or added lines in 1 file covered. (100.0%)

2787 of 3414 relevant lines covered (81.63%)

580243.6 hits per line