jstasiak / python-zeroconf / 558

94%

Pull #232

travis-ci

Optimize handle_response cache check

The handle_response loop would encounter a unique record
it would search the cache in order to remove keys that
matched the DNSEntry for the record.

Since the cache is stored as a list of records with the key as the DNSEntry
key we can avoid searching the entire cache each time and only
search for the DNSEntry of the record. In practice this means
with 5000 entries and records in the cache we now only need to search
4 or 5.

This also fixes a memory leak in the DNSCache.  When all the records for
a given DNSEntry key were removed from the cache, the DNSEntry key
itself that contain the list was never removed.  This left an empty list
in memory for every device that was no longer broadcasting on the
network.

Test environment:

  Home Assistant running on home networking with a /22
  and a significant amount of broadcast traffic

  Testing was done with py-spy v0.3.3
    (https://github.com/benfred/py-spy/releases)

9 of 9 new or added lines in 1 file covered. (100.0%)

2111 of 2254 relevant lines covered (93.66%)

5.57 hits per line