ckeditor / ckeditor5-engine / 5533

100%

push

travis-ci

Merge pull request #1826 from ckeditor/i/6091

Other: `StylesProcessor` rules will not be stored in a singleton, which made them shared between editor instances. In order to allow binding a styles processor instance to a specific view document, we had to replace a dynamic `#document` property in view nodes with a static one, set upon node creation. Closes ckeditor/ckeditor5#6091.

MAJOR BREAKING CHANGES: `EditingController` requires an instance of StylesProcessor in its constructor.

MAJOR BREAKING CHANGES: `DataController` requires an instance of StylesProcessor in its constructor.

MAJOR BREAKING CHANGES: `DomConverter`, `HtmlDataProcessor` and `XmlDataProcessor` require an instance of the view document in their constructors.

MAJOR BREAKING CHANGES: The `View` class requires an instance of `StylesProcessor` as its first argument.

MAJOR BREAKING CHANGES: The `createViewElementFromHighlightDescriptor()` function that is exported by `src/conversion/downcasthelpers.js` file requires an instance of the view document as its first argument.

MAJOR BREAKING CHANGES: Method `view.Document#addStyleProcessorRules()` has been moved to DataController class.

MINOR BREAKING CHANGES: `DataController` does not accept the data processor instance any more.

MAJOR BREAKING CHANGES: The `#document` getter was removed from model nodes. Only the root element holds the reference to the model document. For attached nodes, use `node.root.document` to access it.

5095 of 5095 branches covered (100.0%)

Branch coverage included in aggregate %.

8185 of 8185 relevant lines covered (100.0%)

19669.52 hits per line