jstasiak / python-zeroconf / 554

94%

Pull #232

travis-ci

Optimize handle_response cache check

Test environment:

  Home Assistant running on home networking with a /22
  and a significant amount of broadcast traffic

  Sampling was done with py-spy for a 1000 second period
  3 times before an 3 times after the change with no
  change in network devices and the number of handle_response
  calls varied less than 2% which is well inside the margin
  of error.

  On average between the three profiler runs, the number of
  calls to the __eq__ were reduced as follows:

    Before: __eq__ was 65.75% of handle_response execution time
    After: __eq__ was 28.98% of handle_response execution time

  Testing was done with py-spy v0.3.3
    (https://github.com/benfred/py-spy/releases)

1 of 1 new or added line in 1 file covered. (100.0%)

2107 of 2250 relevant lines covered (93.64%)

5.58 hits per line