LCA-ActivityBrowser / activity-browser / 969

51%

push

travis-ci

Improvements to sankey graph (#368)

* Stealthily remove duplicate sankey code

* Simplify imports from web folder

* Separate json dict creation to static methods

* Use generators in remove_orphaned_nodes

* Sort imports, add typing and static method decorators

* Use set and itertools.chain to somewhat increase speed of inner_exchanges

* HTML - Remove comma from unexpected place

* Add typing to Graph methods, update calls to static methods

* JS - Use existing webchannel instead of creating anew

* Move update signal to bridge

* Create base navigator classes from shared implementations

* Subclass navigator.py Graph from BaseGraph

* Subclass sankey_navigator.py Graph from BaseGraph

* Subclass GraphNavigatorWidget from BaseNavigatorWidget

* Separate graph processing logic into method

* Subclass SankeyNavigatorWidget from BaseNavigatorWidget

* Remove obsolete graphsignals object

* Only send json_data if sankey graph exists/is valid

* JS - Render container before filling with data

* JS - Improve structure of update_graph code

313 of 313 new or added lines in 6 files covered. (100.0%)

4762 of 8129 relevant lines covered (58.58%)

0.59 hits per line