cirello-io / dynamolock / 357

96%

cron

travis-ci

dynamolock: prevent locks from being acquired while closing

This commit fixes a race in Client.Close() that potentially allowed for
new locks to be acquired while closing / releasing all locks.

The race occurs when a call to AcquireLock() is in progress when Close()
is called and when AcquireLock() is called while closing, but before we
set Client.closed to true.

Thanks Daniel Gil (lyft) and Charlie Vieth (lyft)

Squashed commit of the following:

commit f50ab31bf
Author: Daniel Gil <danielgil@lyft.com>
Date:   Thu Feb 20 15:54:57 2020 -0500

    Revert go.mod

commit ac4810bba
Author: Daniel Gil <danielgil@lyft.com>
Date:   Thu Feb 20 15:54:29 2020 -0500

    Remove generated .idea

commit 6ec502aad
Author: Daniel Gil <danielgil@lyft.com>
Date:   Thu Feb 20 15:52:53 2020 -0500

    Fix imports

commit 7ac46aa64
Author: Daniel Gil <danielgil@lyft.com>
Date:   Thu Feb 20 15:42:14 2020 -0500

    Add comment on the test

commit 418226353
Author: Daniel Gil <danielgil@lyft.com>
Date:   Thu Feb 20 15:37:34 2020 -0500

    Remove TODOs

commit c4b884be7
Author: Daniel Gil <danielgil@lyft.com>
Date:   Thu Feb 20 15:36:16 2020 -0500

    Make internal releaseLock just exported ReleaseLock without checking for closed

commit 53f7244cb
Author: Daniel Gil <danielgil@lyft.com>
Date:   Thu Feb 20 15:28:04 2020 -0500

    Remove comment from test

commit c07bc1e76
Author: Daniel Gil <danielgil@lyft.com>
Date:   Tue Feb 18 18:47:24 2020 -0500

    Skip lock check

commit 04de43290
Author: Daniel Gil <danielgil@lyft.com>
Date:   Tue Feb 18 18:44:51 2020 -0500

    Use cev client.go

commit d382865bc
Author: Daniel Gil <danielgil@lyft.com>
Date:   Tue Feb 18 1... (continued)

26 of 26 new or added lines in 1 file covered. (100.0%)

790 of 808 relevant lines covered (97.77%)

1192.74 hits per line