4825

Ran 27 Feb 2020 07:41AM UTC

Jobs 6

Files 0

Run time –

Badge

Embed ▾

pending completion

Build # 4825

Build Type

push

travis-ci-com

Committed by

tyll

Commit Message

nm sriov: Properly return when device not exists

When interface does not exists, the `nm.sriov._has_sriov_capability()`
will raise:

```python
    def _has_sriov_capability(ifname):
        dev = device.get_device_by_name(ifname)
>       if nmclient.NM.DeviceCapabilities.SRIOV & dev.props.capabilities:
E       AttributeError: 'NoneType' object has no attribute 'props'
```

Fixed by add additional check on whether device is None.

Also fixed the integration test which incorrectly using eth0 which is
not test NIC, changed to eth1.

Signed-off-by: Gris Ge <fge@redhat.com>

Run Details

Jobs

ID	Job ID	Ran
2	4825.2 (CONTAINER_IMAGE=nmstate/centos8-nmstate-dev testflags="--test-type integ_slow --pytest-args='-x'")	27 Feb 2020 07:47AM UTC	Travis Job 4825.2
3	4825.3 (CONTAINER_IMAGE=nmstate/centos8-nmstate-dev testflags="--test-type format")	27 Feb 2020 07:41AM UTC	Travis Job 4825.3
4	4825.4 (CONTAINER_IMAGE=nmstate/centos8-nmstate-dev testflags="--test-type lint")	27 Feb 2020 07:44AM UTC	Travis Job 4825.4
5	4825.5 (CONTAINER_IMAGE=nmstate/centos8-nmstate-dev testflags="--test-type unit_py36")	27 Feb 2020 07:47AM UTC	Travis Job 4825.5
6	4825.6 (CONTAINER_IMAGE=nmstate/centos8-nmstate-dev testflags="--test-type integ --pytest-args='-x' --copr networkmanager/NetworkManager-1.22-git")	27 Feb 2020 08:03AM UTC	Travis Job 4825.6
7	4825.7 (CONTAINER_IMAGE=nmstate/centos8-nmstate-dev testflags="--test-type integ --pytest-args='-x' --copr networkmanager/NetworkManager-master")	27 Feb 2020 08:03AM UTC	Travis Job 4825.7

Source Files on build 4825

Detailed source file information is not available for this build.

nmstate / nmstate / 4825

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4825

nmstate / nmstate / 4825

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 4825

README BADGES
x