1834
83%

Ran 25 Feb 2020 03:26PM UTC

Jobs 10

Files 17

Run time 9min

Badge

Embed ▾

Committed 25 Feb 2020 03:24PM UTC coverage: 81.634% (-0.06%) from 81.693%

Build # 1834

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Put zero filler into the SSL handshake packet. (#1066)

According to the linked documentation at
http://dev.mysql.com/doc/internals/en/connection-phase-packets.html#packet-Protocol::SSLRequest
SSLRequest packet should have zero filler similar to the regular handshake request,
but now the driver puts zeros only in the regular request. Luckily vanilla MySQL
doesn't rely on this zero filler and doesn't verify its presence, thus the driver worked
fine so far. But MySQL can change to rely on zeros at any point.

The problem was discovered while testing against a customized MySQL.

Run Details

2787 of 3414 relevant lines covered (81.63%)

576195.09 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	1834.1	25 Feb 2020 03:26PM UTC	81.11	Travis Job 1834.1
2	1834.2	25 Feb 2020 03:26PM UTC	81.11	Travis Job 1834.2
3	1834.3	25 Feb 2020 03:26PM UTC	81.11	Travis Job 1834.3
4	1834.4	25 Feb 2020 03:26PM UTC	81.11	Travis Job 1834.4
5	1834.5	25 Feb 2020 03:28PM UTC	81.11	Travis Job 1834.5
6	1834.6 (DB=MYSQL8)	25 Feb 2020 03:28PM UTC	81.49	Travis Job 1834.6
7	1834.7 (DB=MYSQL57)	25 Feb 2020 03:28PM UTC	81.43	Travis Job 1834.7
8	1834.8 (DB=MARIA55)	25 Feb 2020 03:28PM UTC	80.9	Travis Job 1834.8
9	1834.9 (DB=MARIA10_1)	25 Feb 2020 03:28PM UTC	81.25	Travis Job 1834.9
10	1834.10	25 Feb 2020 03:36PM UTC	81.46	Travis Job 1834.10

Source Files on build 1834

Detailed source file information is not available for this build.

go-sql-driver / mysql / 1834
83%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1834

go-sql-driver / mysql / 1834 83%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1834

go-sql-driver / mysql / 1834
83%

README BADGES
x