ably / ably-ruby / 1086

84%

master: 98%

Pull #196

travis-ci

Use default fallback hosts when custom environment set

When environment is set in the client SDKs, we can now rely on default fallback hosts as follows.

Fallbacks are ENV-[a-e]-fallback.ably-realtime.com. For example:

ENV-a-fallback.ably-realtime.com
ENV-b-fallback.ably-realtime.com
ENV-c-fallback.ably-realtime.com
ENV-d-fallback.ably-realtime.com
ENV-e-fallback.ably-realtime.com

Note that this change:

- It breaks a lot of tests against sandbox that assumed no fallback hosts would be used
- We need to ensure that custom hosts or custom ports result do not use default environment fallback hosts.  We should only use when only the custom environment is set
- Some spec updates are needed in the spec relating to the use of fallback hosts

See related issue https://github.com/ably/docs/issues/818 (no spec yet exists)

50 of 50 new or added lines in 4 files covered. (100.0%)

13161 of 13912 relevant lines covered (94.6%)

7149.45 hits per line