tarantool / tarantool / 20811

83%

master: 88%

push

travis-ci

<a href="https://github.com/tarantool/tarantool/commit/<a class=hub.com/tarantool/tarantool/commit/1d1a9fe87eedef92af4abcda546655fb8438dc02">1d1a9fe87<a href="https://github.com/tarantool/tarantool/commit/1d1a9fe87eedef92af4abcda546655fb8438dc02">&quot;&gt;app: handle concatenated argv name-value correctly

The server used to crash when any option argument was passed with
a value concatenated to it, like this: &amp;#39;-lvalue&amp;#39;, &amp;#39;-evalue&amp;#39;
instead of &amp;#39;-l value&amp;#39; and &amp;#39;-e value&amp;#39;.

However this is a valid way of writing values, and it should not
have crashed regardless of its validity.

The bug was in usage of &amp;#39;optind&amp;#39; global variable from getopt()
function family. It is not supposed to be used for getting an
option&amp;#39;s value. It points to a next argv to parse. Next argv !=
value of current argv, like it was with &amp;#39;-lvalue&amp;#39; and &amp;#39;-evalue&amp;#39;.

For getting a current value there is a variable &#39;optarg&#39;.

Closes #4775

(cherry picked from commit </a><a class="double-link" href="https://github.com/tarantool/tarantool/commit/<a class="double-link" href="https://github.com/tarantool/tarantool/commit/29cfd564132622b63f78e44ccf34555316c5a3cb">29cfd5641</a>">29cfd5641</a><a href="https://github.com/tarantool/tarantool/commit/1d1a9fe87eedef92af4abcda546655fb8438dc02">)

41815 of 50688 relevant lines covered (82.49%)

886675.08 hits per line