apollographql / graphql-tools / 3805

95%

master: 94%

Pull #1284

travis-ci

compat: filter extensions prior to passing to `buildASTSchema`.

.@IvanGoncharov originally brought this to my attention when he pointed me to
https://github.com/yaacovCR/graphql-tools-fork/issues/32#issuecomment-571252686
and suggested stripping extension nodes prior to invoking `buildASTSchema`
as a cross-version (v14 <=> v15) approach for interim compatibility on the
v4 series of `graphql-tools`.

The most urgent and pertinent need here from my perspective is to allow
user-exploration of the new `graphql@15` release candidate within Apollo
Server which currently re-exports the entirety of `graphql-tools` (even
though it only relies on small portions of it).

Upon further investigation of the above-referenced issue, it appears that
@yaacovCR had already crafted the solution that @IvanGoncharov had suggested
to me, which I found in <a class=hub.com/apollographql/graphql-tools/commit/2280eef8ad6c1cbc90c640228eb68094546f60f9">2280eef8a within the
well-organized https://github.com/apollographql/graphql-tools/pull/1206
(which I am thankful for the continued updates on!).

My commit here merely grabs a sub-set of that commit that seemed most
pertinent; I certainly don't claim that this solution is nearly as
comprehensive as the original 2280eef8ad6c1cbc90c640228eb68094546f60f9.  My
hope is that by using the same code/implementation here, it will marginally
lessen future merge conflicts.

Since this is basically a re-working of @yaacovCR's commit, I've attributed
co-authorship of this commit accordingly.  (Thank you, again!)

Ref: https://github.com/apollographql/graphql-tools/issues/1272
Co-authored-by: yaacovCR <yaacovCR@gmail.com>

956 of 1098 branches covered (87.07%)

8 of 8 new or added lines in 3 files covered. (100.0%)

2054 of 2171 relevant lines covered (94.61%)

417.4 hits per line