apollographql / graphql-tools / 3804

95%

master: 94%

push

travis-ci

<a href="https://github.com/apollographql/graphql-tools/commit/<a class=hub.com/apollographql/graphql-tools/commit/66d73a8df2280ca78748ee7a72c08c5ea271c70a">66d73a8df<a href="https://github.com/apollographql/graphql-tools/commit/66d73a8df2280ca78748ee7a72c08c5ea271c70a">&quot;&gt;compat: filter extensions prior to passing to `buildASTSchema`.

.@IvanGoncharov originally brought this to my attention when he pointed me to
https://github.com/yaacovCR/graphql-tools-fork/issues/32#issuecomment-571252686
and suggested stripping extension nodes prior to invoking `buildASTSchema`
as a cross-version (v14 &amp;lt;=&amp;gt; v15) approach for interim compatibility on the
v4 series of `graphql-tools`.

The most urgent and pertinent need here from my perspective is to allow
user-exploration of the new `graphql@15` release candidate within Apollo
Server which currently re-exports the entirety of `graphql-tools` (even
though it only relies on small portions of it).

Upon further investigation of the above-referenced issue, it appears that
@yaacovCR had already crafted the solution that @IvanGoncharov had suggested
to me, which I found in &lt;/a&gt;&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/apollographql/graphql-tools/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/apollographql/graphql-tools/commit/<a class=hub.com/apollographql/graphql-tools/commit/2280eef8ad6c1cbc90c640228eb68094546f60f9">2280eef8a">2280eef8a</a><a href="https://github.com/apollographql/graphql-tools/commit/66d73a8df2280ca78748ee7a72c08c5ea271c70a"> within the
well-organized https://github.com/apollographql/graphql-tools/pull/1206
(which I am thankful for the continued updates on!).

My commit here merely grabs a sub-set of that commit that seemed most
pertinent; I certainly don&#39;t claim that this solution is nearly as
comprehensive as the original 2280eef8ad6c1cbc90c640228eb68094546f60f9.  My
hope is that by using the same code/implementation here, it will marginally
lessen future merge conflicts.

Since this is basically a re-working of @yaacovCR&#39;s commit, I&#39;ve attributed
co-authorship of this commit accordingly.  (Thank you, again!)

Ref: https://github.com/apollographql/graphql-tools/... (continued)

956 of 1098 branches covered (87.07%)

7 of 7 new or added lines in 2 files covered. (100.0%)

2054 of 2171 relevant lines covered (94.61%)

417.38 hits per line