dpkp / kafka-python / 2365

85%

push

travis-ci

<a href="https://github.com/dpkp/kafka-python/commit/<a class=hub.com/dpkp/kafka-python/commit/<a class="double-link" href="https://git"><a class=hub.com/dpkp/kafka-python/commit/<a class="double-link" href="https://git"><a class=hub.com/dpkp/kafka-python/commit/<a class="double-link" href="https://git"><a class=hub.com/dpkp/kafka-python/commit/3c3fdc11b555756c53ae63bfa46a915eab48f448">3c3fdc11b<a href="https://github.com/dpkp/kafka-python/commit/3c3fdc11b555756c53ae63bfa46a915eab48f448">&lt;a href=&quot;https://github.com/dpkp/kafka-python/commit/3c3fdc11b555756c53ae63bfa46a915eab48f448&quot;&gt;&amp;lt;a href=&amp;quot;https://github.com/dpkp/kafka-python/commit/3c3fdc11b555756c53ae63bfa46a915eab48f448&quot;&gt;&amp;lt;a href=&amp;quot;https://github.com/dpkp/kafka-python/commit/3c3fdc11b555756c53ae63bfa46a915eab48f448&amp;quot;&amp;gt;&amp;amp;quot;&amp;amp;gt;KAFKA-8962: Use least_loaded_node() for describe_topics()

In KAFKA-8962 the `AdminClient.describe_topics()` call was changed from
using the controller to using the `least_loaded_node()`:
https://github.com/apache/kafka/commit/&amp;amp;lt;/a&amp;amp;gt;&amp;amp;lt;a class=&amp;amp;quot;double-link&amp;amp;quot; href=&amp;amp;quot;https://github.com/dpkp/kafka-python/commit/&amp;amp;lt;a class=&amp;amp;quot;double-link&amp;amp;quot; href=&amp;amp;quot;https://github.com/dpkp/kafka-python/commit/317089663cc7ff4fdfcba6ee434f455e8ae13acd&amp;amp;quot;&amp;amp;gt;317089663&amp;amp;lt;/a&amp;amp;gt;&amp;amp;quot;&amp;amp;gt;317089663&amp;amp;lt;/a&amp;amp;gt;&amp;amp;lt;a href=&amp;amp;quot;https://github.com/dpkp/kafka-python/commit/3c3fdc11b555756c53ae63bfa46a915eab48f448&amp;amp;quot;&amp;amp;gt;#diff-6869b8fccf6b098cbcb0676e8ceb26a7R1540

As a result, no metadata request/response processing needs to happen
through the controller, so it&amp;amp;#39;s safe to remove the custom
error-checking. Besides, I don&amp;amp;#39;t think this error-checking even added
any value because AFAIK no metadata response would return a
`NotControllerError` because the recipient broker wouldn&amp;amp;#39;t realize the
metadata request was intended for only the controller.

Originally our admin client was implemented using the least-loaded-node,
then later updated to the controller. So updating it back to
least-loaded node is a simple case of reverting the associated commits.

This reverts commit &lt;/a&gt;&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/dpkp/kafka-python/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/dpkp/kafka-python/commit/7195f0369c7dbe25aea2c3fed78d2b4f772d775b&quot;&gt;7195f0369&lt;/a&gt;&quot;&gt;7195f0369&lt;/a&gt;<a href="https://github.com/dpkp/kafka-python/commit/3c3fdc11b555756c53ae63bfa46a915eab48f448">.

This reverts commit </a><a class="double-link" href="https://github.com/dpkp/kafka-python/commit/<a class="double-link" href="https://github.com/dpkp/kafka-python/commit/6e2978edee9a06e9dbe60afcac226b27b83cbc74">6e2978ede</a>">6e2978ede</a><a href="https://github.com/dpkp/kafka-python/commit/3c3fdc11b555756c53ae63bfa46a915eab48f448">.

This reverts commit f92889af7">f92889af7.

3 of 3 new or added lines in 1 file covered. (100.0%)

7288 of 8651 relevant lines covered (84.24%)

19.49 hits per line