garthenweb / react-viewport-utils / 104

73%

push

travis-ci

fix(useViewportEffect): support changing recalculateLayoutBeforeUpdate in combination with deferUpdateUntilIdle

When recalculateLayoutBeforeUpdate is used with a dynamic value in a
function, e.g. useRect, the function is not reassninged to the listener.
This can especially become an issue with deferUpdateUntilIdle.
In the example of useRect, the deferred function will be called with the
old element (which might be null) and the update which is triggered
afterwards containing the new function is not respected any longer.
Afterwards the dependency is not changing any longer, therefore the
state stays undefined.

Using a dynamic function that calls the latest function independent of
when it was registered fixes the issue.

Closes #16

194 of 318 branches covered (61.01%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

445 of 559 relevant lines covered (79.61%)

45.92 hits per line