xolox / python-rotate-backups / 95

93%

master: 93%

push

travis-ci

Merge pull request #23: New timestamp pattern option

The pull request wasn't exactly complete (the code couldn't have run as
written, although it showed the general idea clear enough) so I decided
to treat #23 as more of a feature suggestion. However there was no
reason no to merge the pull request and use it as a base for my changes,
hence why I decided to do so despite rewriting the code.

Changes from the pull request:

- Renamed 'timestamp' to 'timestamp_pattern' (less ambiguous).

- Added validation that custom patterns define named capture
  groups corresponding to all of the required date components.

- Rewrote mapping from capture groups to datetime.datetime() arguments:

  - Previously positional datetime.datetime() arguments were used which
    depended on the order of capture groups in the hard coded regular
    expression pattern to function correctly.

  - Now that users can define their own patterns, this is no longer a
    reasonable approach. As such the code now constructs and passes a
    dictionary of keyword arguments to datetime.datetime().

- Updated documentation and command line interface usage message.

- Added tests for the new behavior.

28 of 28 new or added lines in 2 files covered. (100.0%)

380 of 412 relevant lines covered (92.23%)

6.45 hits per line