8322
39%
master: %

Ran 13 Feb 2020 06:28PM UTC

Jobs 1

Files 86

Run time 13s

Badge

Embed ▾

pending completion

Build # 8322

Build Type

push

travis-ci

Committed by

buger

Commit Message

don't do quota checks on API level or key level if they have -1 value (#2789)

fixes #2777 , #2780

I think this line here is the culprit.

We create a new instance of access rights for each API in the policy and thus the GO runtime sets the default values to 0.  This essentially "turns on" limits for each API.
https://github.com/TykTechnologies/tyk/blob/master/gateway/middleware.go#L371

I believe this function (which runs after key creation), is supposed to cancel out the API level Limits, however it doesn't work correctly and never gets hit because the line above in `middleware.go` instantiates the Limit object.
https://github.com/TykTechnologies/tyk/blob/master/gateway/api.go#L198

This fix leaves the current logic as is, and adds an IF checks to see if Quotas are enabled before performing a quota check.

Run Details

10829 of 17805 relevant lines covered (60.82%)

148.01 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
2	8322.2 (LATEST_GO=true)	13 Feb 2020 06:28PM UTC	0	60.82	Travis Job 8322.2

Source Files on build 8322

Detailed source file information is not available for this build.

TykTechnologies / tyk / 8322
39%
master: %

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 8322

TykTechnologies / tyk / 8322 39% master: %

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 8322

TykTechnologies / tyk / 8322
39%
master: %

README BADGES
x