827
92%
master: 92%

Ran 12 Feb 2020 01:42PM UTC

Jobs 27

Files 29

Run time 5min

Badge

Embed ▾

pending completion

Build # 827

Build Type

Pull #537

travis-ci

Committed by

web-flow

Commit Message

The issue was that base_manager method from django is a cached property that creates a manager each time it is required. So overwriting didnt work. Now i am far from a metaclass expert and im sure this can be done neater, however this is all the time i have at the moment. Improvements shouldnt be too hard now the issue has a (ugly) fix. Also added a short test, but i am used to pytest, so forgive me for the ugly manager solution. Hope this can help you out

Pull Request Pull Request #537: base_manager shouldnt be the same as default_manager

Run Details

39 of 39 new or added lines in 2 files covered. (100.0%)

3693 of 4021 relevant lines covered (91.84%)

24.69 hits per line

New Missed Lines in Diff

Lines	Coverage	∆	File
5	93.17	-1.35%	modeltranslation/translator.py

Jobs

ID	Job ID	Ran	Files	Coverage
1	827.1 (DJANGO=1.11 DB=sqlite)	12 Feb 2020 01:42PM UTC	29	91.44	Travis Job 827.1
2	827.2 (DJANGO=1.11 DB=sqlite)	12 Feb 2020 01:42PM UTC	29	91.44	Travis Job 827.2
3	827.3 (DJANGO=1.11 DB=sqlite)	12 Feb 2020 01:42PM UTC	29	91.44	Travis Job 827.3
4	827.4 (DJANGO=1.11 DB=postgres)	12 Feb 2020 01:42PM UTC	29	91.59	Travis Job 827.4
5	827.5 (DJANGO=1.11 DB=postgres)	12 Feb 2020 01:42PM UTC	29	91.59	Travis Job 827.5
6	827.6 (DJANGO=1.11 DB=postgres)	12 Feb 2020 01:43PM UTC	29	91.59	Travis Job 827.6
7	827.7 (DJANGO=1.11 DB=mysql)	12 Feb 2020 01:43PM UTC	29	91.44	Travis Job 827.7
8	827.8 (DJANGO=1.11 DB=mysql)	12 Feb 2020 01:43PM UTC	29	91.44	Travis Job 827.8
9	827.9 (DJANGO=1.11 DB=mysql)	12 Feb 2020 01:43PM UTC	29	91.44	Travis Job 827.9
10	827.10 (DJANGO=2.1 DB=sqlite)	12 Feb 2020 01:43PM UTC	29	91.4	Travis Job 827.10
11	827.11 (DJANGO=2.1 DB=sqlite)	12 Feb 2020 01:44PM UTC	29	91.4	Travis Job 827.11
12	827.12 (DJANGO=2.1 DB=postgres)	12 Feb 2020 01:44PM UTC	29	91.54	Travis Job 827.12
13	827.13 (DJANGO=2.1 DB=postgres)	12 Feb 2020 01:44PM UTC	29	91.54	Travis Job 827.13
14	827.14 (DJANGO=2.1 DB=mysql)	12 Feb 2020 01:44PM UTC	29	91.4	Travis Job 827.14
15	827.15 (DJANGO=2.1 DB=mysql)	12 Feb 2020 01:44PM UTC	29	91.4	Travis Job 827.15
16	827.16 (DJANGO=2.2 DB=sqlite)	12 Feb 2020 01:45PM UTC	29	91.4	Travis Job 827.16
17	827.17 (DJANGO=2.2 DB=sqlite)	12 Feb 2020 01:45PM UTC	29	91.4	Travis Job 827.17
18	827.18 (DJANGO=2.2 DB=postgres)	12 Feb 2020 01:45PM UTC	29	91.54	Travis Job 827.18
19	827.19 (DJANGO=2.2 DB=postgres)	12 Feb 2020 01:45PM UTC	29	91.54	Travis Job 827.19
20	827.20 (DJANGO=2.2 DB=mysql)	12 Feb 2020 01:45PM UTC	29	91.4	Travis Job 827.20
21	827.21 (DJANGO=2.2 DB=mysql)	12 Feb 2020 01:46PM UTC	29	91.4	Travis Job 827.21
22	827.22 (DJANGO=3.0a1 DB=sqlite)	12 Feb 2020 01:46PM UTC	29	91.4	Travis Job 827.22
23	827.23 (DJANGO=3.0a1 DB=sqlite)	12 Feb 2020 01:46PM UTC	29	91.4	Travis Job 827.23
24	827.24 (DJANGO=3.0a1 DB=postgres)	12 Feb 2020 01:46PM UTC	29	91.54	Travis Job 827.24
25	827.25 (DJANGO=3.0a1 DB=postgres)	12 Feb 2020 01:46PM UTC	29	91.54	Travis Job 827.25
26	827.26 (DJANGO=3.0a1 DB=mysql)	12 Feb 2020 01:48PM UTC	29	91.4	Travis Job 827.26
27	827.27 (DJANGO=3.0a1 DB=mysql)	12 Feb 2020 01:47PM UTC	29	91.4	Travis Job 827.27

deschler / django-modeltranslation / 827
92%
master: 92%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Jobs

Source Files on build 827

deschler / django-modeltranslation / 827 92% master: 92%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Jobs

Source Files on build 827

deschler / django-modeltranslation / 827
92%
master: 92%

README BADGES
x