puppetlabs / pdk / 3173
91%
master: 92%

LAST BUILD BRANCH: main
DEFAULT BRANCH: master
Ran
Jobs 1
Files 110
Run time 12s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
3173

Pull #842

travis-ci

web-flow 
(PDK-1113) Use PDK configuration instead of AnswerFile class

Previously the PDK had two ways to retrieve the same configuration information.
One via the PDK::Config classes and the other the AnswerFile class.  This should
only be one.  This commit removes the AnswerClass (and associated features) and
instead uses PDK::Config for setting management

* Removes the PDK::AnswerFile class, and instead has a single helper method for
  the default file location.  This may eventually be moved into the PDK::Config
  namespace as well

* Removes the hidden `--answer-file` command line option and instead uses an
  environment variable PDK_ANSWER_FILE.  This feature is not supported and is
  only used to acceptance testing.  Note that we moved to an environment
  variable as there was a subtle race condition where the CLI reads from
  PDK::Config, but the CLI also moves the user answer file location. By using
  an environment variable this race condition can no longer occur.

* Move setting reads from PDK.answers to PDK.config.pdk_setting(....)

* Move setting writes from PDK.answers.update! to
  PDK.config.user['module_defaults']['....'] =

* Modify tests for the setting read/write changes

* Added a Mock configuration RSpec Context to stop any test information
  affecting actual real setting files.  Previously module answer files were
  being modified
Pull Request #842: (PDK-1113) Use PDK configuration instead of AnswerFile class

100 of 100 new or added lines in 14 files covered. (100.0%)

1897 of 4908 relevant lines covered (38.65%)

1.95 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
1
64.29
 -4.95% lib/pdk/cli/config.rb
1
37.5
 -2.5% lib/pdk/cli/config/get.rb
1
53.13
 -46.88% lib/pdk/cli/convert.rb
1
71.05
 -28.95% lib/pdk/config/setting.rb
2
64.29
 -35.71% lib/pdk/util.rb
3
45.63
 -52.33% lib/pdk/config/namespace.rb
4
79.41
 -14.87% lib/pdk.rb
4
69.23
 lib/pdk/cli/get.rb
4
41.22
 -58.78% lib/pdk/util/template_uri.rb
8
8.06
 -91.12% lib/pdk/generate/module.rb
9
40.0
 lib/pdk/cli/get/config.rb
17
52.87
 -41.86% lib/pdk/config.rb

Uncovered Existing Lines

Lines Coverage ∆ File
1
92.31
 -7.69% lib/pdk/generate.rb
1
79.41
 -14.87% lib/pdk.rb
1
95.65
 -4.35% lib/pdk/validate.rb
2
86.67
 -13.33% lib/pdk/cli/errors.rb
2
75.0
 -25.0% lib/pdk/cli/module/build.rb
2
77.78
 -22.22% lib/pdk/config/validator.rb
2
80.0
 -20.0% lib/pdk/module/template_dir/local.rb
3
47.92
 -6.25% lib/pdk/config/json_schema_namespace.rb
3
80.0
 -20.0% lib/pdk/module.rb
4
66.67
 -26.67% lib/pdk/cli/util/command_redirector.rb
5
0.0
 -100.0% lib/pdk/config/errors.rb
7
0.0
 -66.67% lib/pdk/cli/util/spinner.rb
7
50.0
 -50.0% lib/pdk/validate/metadata_validator.rb
7
50.0
 -50.0% lib/pdk/validate/puppet_validator.rb
7
50.0
 -50.0% lib/pdk/validate/ruby_validator.rb
7
50.0
 -50.0% lib/pdk/validate/tasks_validator.rb
7
50.0
 -50.0% lib/pdk/validate/yaml_validator.rb
8
61.9
 -38.1% lib/pdk/cli/release/prep.rb
8
52.94
 -47.06% lib/pdk/util/filesystem.rb
9
37.5
 -56.25% lib/pdk/config/json.rb
9
47.06
 -52.94% lib/pdk/control_repo.rb
10
37.5
 -62.5% lib/pdk/cli/new/class.rb
10
37.5
 -62.5% lib/pdk/cli/new/defined_type.rb
10
41.18
 -58.82% lib/pdk/cli/new/task.rb
10
71.05
 -28.95% lib/pdk/config/setting.rb
10
47.37
 -52.63% lib/pdk/generate/defined_type.rb
10
47.37
 -52.63% lib/pdk/generate/puppet_class.rb
11
35.29
 -64.71% lib/pdk/config/yaml.rb
12
45.45
 -54.55% lib/pdk/cli/release/publish.rb
12
36.84
 -63.16% lib/pdk/cli/util/option_normalizer.rb
12
44.44
 -44.44% lib/pdk/generate/task.rb
12
47.83
 -52.17% lib/pdk/util/version.rb
13
72.84
 -13.91% lib/pdk/cli.rb
13
36.05
 -15.12% lib/pdk/cli/release.rb
13
53.57
 -46.43% lib/pdk/cli/util/option_validator.rb
13
34.62
 -50.0% lib/pdk/logger.rb
14
53.13
 -46.88% lib/pdk/cli/convert.rb
14
52.38
 -33.33% lib/pdk/cli/exec.rb
15
40.0
 -60.0% lib/pdk/validate/puppet/puppet_lint.rb
16
36.0
 -64.0% lib/pdk/cli/update.rb
16
40.74
 -59.26% lib/pdk/template_file.rb
19
38.71
 -61.29% lib/pdk/cli/new/module.rb
20
31.03
 -68.97% lib/pdk/cli/new/test.rb
20
35.48
 -64.52% lib/pdk/validate/metadata/metadata_json_lint.rb
21
29.03
 -67.74% lib/pdk/cli/module/generate.rb
21
34.38
 -65.63% lib/pdk/validate/ruby/rubocop.rb
21
28.57
 -50.0% lib/pdk/validate/tasks/name.rb
22
52.87
 -41.86% lib/pdk/config.rb
24
60.26
 -30.77% lib/pdk/util/ruby_version.rb
27
28.57
 -64.29% lib/pdk/module/template_dir/git.rb
28
20.83
 -58.33% lib/pdk/validate/metadata/metadata_syntax.rb
29
29.27
 -70.73% lib/pdk/cli/util/interview.rb
29
25.49
 -56.86% lib/pdk/validate/yaml/syntax.rb
30
23.08
 -76.92% lib/pdk/module/template_dir.rb
31
30.77
 -59.62% lib/pdk/cli/exec/interactive_command.rb
31
22.22
 -68.89% lib/pdk/util/changelog_generator.rb
31
22.03
 -52.54% lib/pdk/validate/tasks/metadata_lint.rb
32
27.27
 -72.73% lib/pdk/util/puppet_strings.rb
34
38.18
 -61.82% lib/pdk/validate/puppet/puppet_epp.rb
34
38.18
 -61.82% lib/pdk/validate/puppet/puppet_syntax.rb
36
26.53
 -73.47% lib/pdk/cli/test/unit.rb
43
15.15
 -43.43% lib/pdk/module/template_dir/base.rb
43
64.29
 -35.71% lib/pdk/util.rb
45
32.35
 -66.18% lib/pdk/module/metadata.rb
45
20.69
 -77.59% lib/pdk/report.rb
46
0.0
 -75.0% lib/pdk/cli/exec_group.rb
50
26.47
 -73.53% lib/pdk/module/update.rb
51
45.63
 -52.33% lib/pdk/config/namespace.rb
54
17.65
 -79.41% lib/pdk/cli/validate.rb
54
23.42
 -48.65% lib/pdk/module/build.rb
56
59.72
 -38.89% lib/pdk/cli/util.rb
59
27.88
 -56.73% lib/pdk/util/git.rb
65
28.13
 -67.71% lib/pdk/generate/puppet_object.rb
66
20.24
 -78.57% lib/pdk/module/update_manager.rb
67
43.85
 -51.54% lib/pdk/util/puppet_version.rb
73
41.22
 -58.78% lib/pdk/util/template_uri.rb
77
17.0
 -77.0% lib/pdk/validate/base_validator.rb
87
19.2
 -69.6% lib/pdk/cli/exec/command.rb
95
25.38
 -73.08% lib/pdk/module/release.rb
97
23.26
 -75.19% lib/pdk/report/event.rb
102
23.88
 -76.12% lib/pdk/util/bundler.rb
105
8.06
 -91.12% lib/pdk/generate/module.rb
108
13.08
 -83.08% lib/pdk/tests/unit.rb
118
18.0
 -78.67% lib/pdk/module/convert.rb
Jobs
ID Job ID Ran Files Coverage
4 3173.4 (2.4.3, CHECK=spec:coverage) 110
38.65
 Travis Job 3173.4
Source Files on build 3173