ladybug-tools / honeybee-radiance / 82

81%

Pull #33

travis-ci

feat(properties): Add extension properties for all Model obects

This commit adds extension properties for all geometry objects (Room, Face, Aperture, Door) and the Model object.

I still have to add some more tests but this code is ready for review, @mostapha .  There are still a should of things that need to be figured out:

* I was trying to implement some form of states in the Aperture properties at first but I saw the implementation of States in the older HoneybeePlus and I don't know how you see dynamic shade geometry working in a setup where you can assign shades to apertures. Given how the schema is set up, this assignment might actually interfere with how you were previously using shade states or it might end up being unnecessary/redundant unless you want to have all of the shades assigned to an Aperture on a single state.

* I don't know how you want to write out indoor vs outdoor shades (right now, the methods that translate to.rad are writing the object and all sub-objects so there's no distinction between indoor and outdoor shades) I think I will need a crash course in the radiance folder structure to understand how these should be changed.

* Should the modifiers be written into the same file as the geometry when translating a Model.to.rad?

728 of 728 new or added lines in 12 files covered. (100.0%)

2897 of 3485 relevant lines covered (83.13%)

2.49 hits per line