• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

optimizely / javascript-sdk / 1240
78%

Build:
DEFAULT BRANCH: master
Ran 29 Jan 2020 10:55PM UTC
Jobs 7
Files 59
Run time 7min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
1240

push

travis-ci

web-flow
chore (Regression Test)[CJS-3815]: Add tests for passing in a custom condition evaluator (#389)

## Summary
#288 introduced an exploratory new feature, the ability to pass custom condition evaluators to the SDK constructor via the option `UNSTABLE_conditionEvaluators`.

The AudienceEvaluator (and its tests) were refactored as a part of that PR, but no tests were added to assert that the `UNSTABLE_conditionEvaluators` worked when passed.

This PR introduces tests to ensure that functionality continues to work.

## Test plan
Unit tests added to assert that:
- You cannot override the built in `custom_attribute` evaluator
- A passed in custom condition evaluator will evaluate conditions of that type
- That the audience condition, user attributes, and logger instance are all passed to the custom evaluator

## Issues
- CJS-3815

637 of 703 branches covered (90.61%)

Branch coverage included in aggregate %.

6675 of 6803 relevant lines covered (98.12%)

162.54 hits per line

Jobs
ID Job ID Ran Files Coverage
2 1240.2 29 Jan 2020 10:55PM UTC 0
97.42
Travis Job 1240.2
5 1240.5 29 Jan 2020 11:01PM UTC 0
97.42
Travis Job 1240.5
6 1240.6 29 Jan 2020 11:03PM UTC 0
97.42
Travis Job 1240.6
7 1240.7 29 Jan 2020 11:02PM UTC 0
97.42
Travis Job 1240.7
8 1240.8 29 Jan 2020 11:02PM UTC 0
97.42
Travis Job 1240.8
9 1240.9 29 Jan 2020 11:02PM UTC 0
97.42
Travis Job 1240.9
10 1240.10 29 Jan 2020 11:02PM UTC 0
97.42
Travis Job 1240.10
Source Files on build 1240
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #1240
  • bc84698e on github
  • Prev Build on master (#1238)
  • Next Build on master (#1250)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc