zopefoundation / zope.interface / 451

99%

master: 99%

Pull #164

travis-ci

The _empty singleton has no-op subscribe/unsubscribe methods.

Turns out they can be called in some very strange error cases. See #162 and #163 for details.

This should fix #162 (at least the provided test case, five.intid, passes now).

It also does enough work on #163 that (a) the test can be written and run in pure-python mode, which was needed to debug it and (b) five.intid runs in pure-python mode (well, with a bunch of other small hacks to Acquisition, ExtensionClass, DocumentTemplate and AccessControl), but I won't claim that it fully fixes #163. For one thing, there are no specific tests. For another, I see more such differences.

1111 of 1127 branches covered (98.58%)

Branch coverage included in aggregate %.

23 of 23 new or added lines in 3 files covered. (100.0%)

9070 of 9156 relevant lines covered (99.06%)

12.66 hits per line