flask-restful / flask-restful / 1144

94%

push

travis-ci

Fix wrongly parsed Decimal fields (#855)

* Add test proving the Decimal issue

* Stop passing the field name to the Decimal constructor

When special-casing the request parser for Decimal, passing the name of
the field as second argument is incorrect.

The second argument of Decimal is a context. Python 3 checks this is in
fact a context, whereas Python 2 ignores it if not needed. This means in
Python 3 that special case line is never successful, so it is handled
below. However, there is a difference: the first converts to string, the
second does not. This results in different values of Decimal being
parsed.

280 of 318 branches covered (88.05%)

1 of 1 new or added line in 1 file covered. (100.0%)

804 of 856 relevant lines covered (93.93%)

22.44 hits per line