gap-system / gap / 11403

4%

Build Type

push

travis-ci

Committed by fingolfin

Commit Message

julia: remove the need for GAPTypes.jl

... by doing something moderately evil: If GAP is loaded before Julia, we
create the Julia type `ForeignGAP.MPtr` *without* a super type. Then once
Julia is loaded, and the type `GAP.GapObj` has been created, GAP.jl calls the
new function `GAP_register_GapObj` with this type as argument, and we patch
`ForeignGAP.MPtr` to have `GAP.GapObj` as supertype.

This seems to work well in practice and ought to be safe, as prior to the
moment were we change the super type, no Julia code beyond the Julia GC should
have ever "seen" `ForeignGAP.MPtr` or any instances of it, and hence no
internal data structures of the Julia runtime that might get into an invalid
state due to our change (e.g. anything related to method dispatch) should
reference it.

Also, *don't* set `GapObj` as supertype for `ForeignGAP.Bag` and
`ForeignGAP.LargeBag`, doing that was IMHO simply a mistake. In practice it
should not have mattered so far, as no regular Julia code ever touches
instances of these types directly. This might change in the future though, if
we introduce Julia wrapper objects for GAP objects that directly access their
underlying bits, instead of going through libgap APIs.

Run Details

4 of 15 new or added lines in 1 file covered. (26.67%)

116 existing lines in 3 files now uncovered.

286935 of 338434 relevant lines covered (84.78%)

28995234.77 hits per line