sindresorhus / eslint-plugin-unicorn / 1511

98%

master: 99%

Pull #503

travis-ci

fix(`prefer-modern-dom-apis`): Ignore other cases where node return value is used

- Where parent is an `ArrayExpression`, `IfStatement`, `'MemberExpression`,  `Property`, `ReturnStatement`

Fixes a test which made a fix which would break because of an inability of the replacement API to return a value.

Also provides minor optimization to avoid declaring fixer with value when not needed.

Also applies (and for `prefer-node-*` rules, switches from) checking `ExpressionStatement` in favor of specific parents (BinaryExpression, CallExpression, ConditionalExpression, LogicalExpression, UnaryExpression), since in theory, the last part of `parentNode.insertBefore(alfa, beta).insertBefore(charlie, delta);` could be checked if the rule were changed to allow such parent expressions rather than requiring a parent member to be a name only (i.e., fixing `parentNode` in `parent.insertBefore()` but ignoring `some.expression().insertBefore()`) since technically such a replacement could be made.

1576 of 1650 branches covered (95.52%)

6 of 6 new or added lines in 2 files covered. (100.0%)

2199 of 2243 relevant lines covered (98.04%)

419.78 hits per line