Coveralls logob
Coveralls logo
  • Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

PHPCSStandards / PHPCSUtils / 111
96%
develop: 99%

Build:
LAST BUILD BRANCH: passedparams/add-extra-test
DEFAULT BRANCH: develop
Ran 22 Jan 2020 05:18AM UTC
Jobs 4
Files 10
Run time 2min
Badge
Badge Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

22 Jan 2020 - 4:48 coverage: 95.82% (+0.2%) from 95.596%
111

Pull #28

travis-ci-com

9181eb84f9c35729a3bad740fb7f9d93?size=18&default=identiconweb-flow
ObjectDeclarations::getName(): improved handling of parse errors

While certain names may be invalid, such as construct names starting with a number, for the purpose of alerting users to these invalid names, the `getName()` method should be able to pick up on them.

The `getName()` method has now been adjusted to allow for such names.

The way this has been implemented also improves the parse error resilience for the `getName()` method.

The `getName()` method could previously inadvertently misidentify the name of a structure in the case of parse errors/live coding as it looked for the first `T_STRING` after the keyword without limiting it to the declaration statement. This has now also been fixed.

The method will now return `null`, both when passed  an anonymous class/function as well as in case of a parse error.

Included additional unit tests.
Pull Request #28: Objectdeclarations::getName(): various improvements

22 of 22 new or added lines in 1 file covered. (100.0%)

894 of 933 relevant lines covered (95.82%)

52.89 hits per line

Jobs
ID Job ID Ran Files Coverage
29 111.29 (LINT=1 PHPCS_VERSION="dev-master" COVERALLS_VERSION="^2.0") 22 Jan 2020 05:18AM UTC 10
92.26
Travis Job 111.29
30 111.30 (PHPCS_VERSION="2.9.2" COVERALLS_VERSION="^2.0") 22 Jan 2020 05:18AM UTC 10
92.79
Travis Job 111.30
31 111.31 (LINT=1 PHPCS_VERSION="dev-master" COVERALLS_VERSION="^1.0") 22 Jan 2020 05:19AM UTC 10
90.98
Travis Job 111.31
32 111.32 (PHPCS_VERSION="2.6.0" COVERALLS_VERSION="^1.0") 22 Jan 2020 05:20AM UTC 10
90.89
Travis Job 111.32
Source Files on build 111
  • Tree
  • List 10
  • Changed 2
  • Source Changed 2
  • Coverage Changed 2
Coverage ∆ File Lines Relevant Covered Missed Hits/Line
  • Back to Repo
  • Travis Build #111
  • Pull Request #28
  • PR Base - develop (#42)
Troubleshooting · Open an Issue · Sales · Support · ENTERPRISE · CAREERS · STATUS
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2023 Coveralls, Inc