|
Ran
|
Jobs
4
|
Files
7
|
Run time
1min
|
Badge
README BADGES
|
push
travis-ci
<a href="https://github.com/uber-go/tally/commit/<a class=hub.com/uber-go/tally/commit/f874b521696eb1aa795250fbb18e59fb76ecd8f0">f874b5216<a href="https://github.com/uber-go/tally/commit/f874b521696eb1aa795250fbb18e59fb76ecd8f0">">m3: Remove atomic from TCalcTransport (#119) The TCalcTransport is used by a single caller at a time, with a mutex used to protect access: https://github.com/uber-go/tally/blob/</a><a class="double-link" href="https://github.com/uber-go/tally/commit/<a class="double-link" href="https://github.com/uber-go/tally/commit/5431c04afc0bad76ce91ca3d549abb469abd2a10">5431c04af</a>">5431c04af</a><a href="https://github.com/uber-go/tally/commit/f874b521696eb1aa795250fbb18e59fb76ecd8f0">/m3/reporter.go#L400 The thrift generated code will only call `Write` serially, so there's no need to use atomics here. Removal of atomics gives a small performance improvement (10-15%): ``` > benchcmp -best old new benchmark old ns/op new ns/op delta BenchmarkCalulateSize 538 453 -15.80% ```
962 of 1029 relevant lines covered (93.49%)
614.32 hits per line
| ID | Job ID | Ran | Files | Coverage | |
|---|---|---|---|---|---|
| 1 | 495.1 | 0 |
93.49 |
Travis Job 495.1 | |
| 2 | 495.2 | 0 |
93.49 |
Travis Job 495.2 | |
| 3 | 495.3 | 0 |
93.49 |
Travis Job 495.3 | |
| 4 | 495.4 | 0 |
93.49 |
Travis Job 495.4 |