OCA / maintainer-quality-tools / 1752
63%
master: 70%

LAST BUILD BRANCH: remove-pycparser-temp-fix-sbi
DEFAULT BRANCH: master
Ran
Jobs 3
Files 7
Run time 4min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
1752

Pull #618

travis-ci

web-flow 
[IMP] Add Prettier and ESLint with --fix

This commit includes:

- Using https://prettier.io/ for supported file formats (these include CSS, SCSS, JS, HTML, MD, YAML and others; see website).
- Transform `.eslintrc` (deprecated) to `.eslintrc.yml`, which supports more advanced syntax.
- Simplify `.eslintrc.yml` removing disabled checks. All checks are disabled by default anyways.
- Remove from `.eslintrc.yml` all stylistic checks that would conflict with Prettier.
- Add `Promise` as a builtin for v13 (this was missed before, so I take this chance to add that).
- Format properly `.travis.yml` so that when it gets merged downstream it gets less diffs when passed trhough Prettier.
- Use `eslint --fix` so we get less warnings and more fixes.
- Add prettier ignoration tags to README.md template, to avoid double-formatting addons table section.
- Ignore for now README.md files to avoid overcomplicating maintenance of those files.

Some insights:

- See https://github.com/OCA/web/pull/1441 as an example of how a web repo looks after this change.
- A beta XML Prettier plugin exists, which could be used in the future to autoformat XML files too!
  - But it's not usable for us right now, as you can see in https://github.com/prettier/plugin-xml/issues/13#issuecomment-555446753
  - Once that's fixed, we can use a configuration similar to https://github.com/prettier/plugin-xml/issues/17#issuecomment-555445966 to integrate here.
Pull Request #618: [IMP] Add Prettier and ESLint with --fix

522 of 823 relevant lines covered (63.43%)

1.89 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
2
89.29
 -1.43% travis/getaddons.py
3
80.65
 -9.68% travis/travis_run_tests
28
82.29
 -15.96% travis/self_tests
208
11.4
 -76.47% travis/test_server.py
Jobs
ID Job ID Ran Files Coverage
5 1752.5 (VERSION="" TESTS="0" LINT_CHECK="1" PYLINT_EXPECTED_ERRORS="35") 7
62.7
 Travis Job 1752.5
6 1752.6 (VERSION="" TESTS="0" LINT_CHECK="1" PYLINT_EXPECTED_ERRORS="36") 7
63.06
 Travis Job 1752.6
7 1752.7 (VERSION="" TESTS="0" LINT_CHECK="1" PYLINT_EXPECTED_ERRORS="36") 7
63.06
 Travis Job 1752.7
Source Files on build 1752