jlfwong / speedscope / 662

47%

push

travis-ci

Trace event: Prevent event re-ordering from generating incorrect flamegraphs (#252)

The code to import trace formatted events intentionally re-orders events in order to make it easier at flamegraph construction time to order the pushes and pops of frames.

It turns out that this re-ordering results in incorrect flamegraphs being generated as shown in #251.

This PR fixes this by avoiding re-ordering in situations where it isn't necessary.

872 of 1983 branches covered (43.97%)

Branch coverage included in aggregate %.

12 of 12 new or added lines in 1 file covered. (100.0%)

2208 of 4558 relevant lines covered (48.44%)

6774.15 hits per line