rytilahti / python-miio / 1475

74%

push

travis-ci

Refactoring: Split Device class into Device+Protocol (#592)

* Extract command-sending functionality from Device class to new CommandSender class to separate concerns

* Rename CommandSender class to Protocol to better describe what it is
Rename do_discover() to send_handshake() & create a proxy method send_handshake() in Device class

* Device: bring back ip and token

* airfresh_t2017.py: fix tests after merge

* tests: bring back `return_values` to simplify the diff

* Device: update deprecation message

* Device: make protocol field private; don't deprecate Device.send method to keep everything compatible.
Protocol: update docstring to reflect new code.
Vacuum: expose raw_id from the Protocol.

* Rename Protocol class to MiIOProtocol

519 of 880 branches covered (58.98%)

Branch coverage included in aggregate %.

191 of 191 new or added lines in 25 files covered. (100.0%)

3635 of 4750 relevant lines covered (76.53%)

1.53 hits per line