recurly / recurly-js / 2888

92%

master: 91%

Build Type

push

travis-ci

Committed by Christopher Rogers

Commit Message

Fixes HostedFields reset on re-configuration preceding initialization
- Fixes #570
- When `recurly.configure` was called during readyState 1, it was not
  possible to reset hosted fields.

Scenario
- `recurly.configure`[1] instantiates `recurly.hostedFields`. The
  fields are created.
- the fields are removed from the DOM prior to emission of the ready
  message
  => the advancement listener does not increment `recurly.readyState`,
     which remains `1`
- `recurly.configure`[2...] is called, and the reset routine is bypassed
  due to incompatible readyState

Solution
- This allows reset to occur at `readyState > 0`, essentially any time
  the hostedFields have begun initialization.
- If, during reset, the current readyState is 1, the awaiting listeners
  are abandoned in order to prevent the stale advancement listener from
  interfering with the new readiness state to be generated post-reset

Lesson
- readyState is not a good pattern.

Run Details

140 of 1372 branches covered (10.2%)

451 of 2676 relevant lines covered (16.85%)

0.89 hits per line