153
97%

Ran 13 Jun 2015 10:18AM UTC

Jobs 1

Files 108

Run time 12s

Badge

Embed ▾

pending completion

Build # 153

Build Type

push

travis-ci

Committed by

tomhughes

Commit Message

Fix bug allowing created elements to reference deleted ones

The bug allows a newly-created element to refer to a deleted one
if the transactions for both overlap. Precisely, the issue is that
the check that an element exists does not prevent a concurrent
transaction from altering that row.

Because "deleting" an element in the OSM database does not remove
the row, we cannot rely on FK constraints to ensure the correct
behaviour. Instead, this fix relies on manually locking referenced
elements.

Note that this "fix" is suboptimal, as it does not allow any
updates to the referenced elements. Updates which do not delete
the row could safely be done, but will be prevented.

Also, it's not clear what the negative performance impact of this
change will be.

Run Details

5961 of 6270 relevant lines covered (95.07%)

64543.59 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	153.1 (1.9.3)	13 Jun 2015 10:18AM UTC	0	95.07	Travis Job 153.1

Source Files on build 153

Detailed source file information is not available for this build.

openstreetmap / openstreetmap-website / 153
97%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 153

openstreetmap / openstreetmap-website / 153 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 153

openstreetmap / openstreetmap-website / 153
97%

README BADGES
x