cucumber / cucumber-jvm / 3639

86%

push

travis-ci

[Spring] Fix BeanDefinitionOverrideException when executing in parallel (#1856)

The SpringFactory register beans with the application context. Because the
application context is shared between threads step definitions may have already
been registered as beans by another thread.

This is trivially fixed by checking if the bean was already registered via
`registry.containsBeanDefinition(beanName))`

However because SpringFactory supports two different ways of running Cucumber
either via cucumber.xml or annotation based configuration this was hard to
understand. By extracting adaptors for each case this becomes clear again.

Fixes: #1855

85 of 85 new or added lines in 3 files covered. (100.0%)

5894 of 7014 relevant lines covered (84.03%)

0.84 hits per line