indico / flask-multipass / 208

56%

push

travis-ci

Make LDAP provider Python3-compatible (#30)

* Install ldap and run associated tests regardless of python version.

* Add urlparse compat import.

* Remove references to `unicode` and fix `to_bytes_recursive` implementation.

* Convert dict_values to a list, since it is a view in py3.

* Fix implementation of `to_unicode` to handle str in python 3.

* Remove use of deprecated Exception.message attribute.

* Only cast to bytes on python 2. This may no longer be needed in any case per the python-ldap docs.

* Fix python 3.7 changes to StopIteration in generators.

See https://stackoverflow.com/questions/51700960/runtimeerror-generator-raised-stopiteration-every-time-i-try-to-run-app

* Remove use of Exception.message (removed in python 3).

* Install python-ldap in travis on python 3.

* Update travis setup and conftest.

* Address code review comments.

* Move imports around.

* Fix remaining Python 3 issues with LDAP

- Disable bytes_mode in python2 (always use unicode for strings)
- Ensure we always return unicode data
- Remove unnecessary type conversions

Co-authored-by: Adrian <adrian.moennich@cern.ch>

930 of 1830 branches covered (50.82%)

2886 of 5381 relevant lines covered (53.63%)

4.29 hits per line