38218
33%

Ran 02 Jan 2020 10:54AM UTC

Jobs 1

Files 555

Run time 41s

Badge

Embed ▾

pending completion

Build # 38218

Build Type

push

travis-ci

Committed by

kevingranade

Commit Message

Fix crash in item comparison when using filter

Fixes #34046.

Using the search filter causes all the inventory_entry objects to be
recreated, so it's not safe to store a pointer to them.

A previous attempt to solve this (#36139) stored copies of the
inventory_entry objects, but that was also unsafe.

This attempt instead stores just pointers to the underlying items.  This
seems to prevent the crashes.

The behaviour of the window is still not always exactly correct, because
using the filter will violate the invariant that the items in the
compared vector correspond to the selected entries.  I don't see a way
to fix that in general -- sometimes the compared item is filtered out,
and thus you can't possibly select the entry (because it doesn't exist).
We might want to add something that does its best to select the right
entries when the filter changes, but this is a sufficiently niche use
case that I'm not sure it's worth the complexity.  I've settled for just
fixing the crash for now.

Run Details

39081 of 141597 relevant lines covered (27.6%)

534833.66 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
10	38218.10 (COMPILER=g++-6 CODE_COVERAGE=true)	02 Jan 2020 10:54AM UTC	555	27.6	Travis Job 38218.10

CleverRaven / Cataclysm-DDA / 38218
33%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 38218

CleverRaven / Cataclysm-DDA / 38218 33%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 38218

CleverRaven / Cataclysm-DDA / 38218
33%

README BADGES
x