• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

hgrecco / pint / 1487
91%

Build:
DEFAULT BRANCH: master
Ran 28 Dec 2019 03:02AM UTC
Jobs 6
Files 210
Run time 8min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
1487

push

travis-ci

web-flow
Merge #842

842: Missing conversion definition when mutating context transformations. r=hgrecco a=dcupif

Thanks for the library, we use it at our company and it's proven
really helpful so far. We are currently moving to Python 3.7 which
made me spot a potential bug in the `BaseRegistry` class (some
of our tests failed when upgrading).

Everything runs fine in Python 3.5, but in 3.7, we are getting a
`DimensionalityError` resulting from the ill-definition of a conversion.
Root cause is that we are mutating context transformations while
iterating over it.

This PR aims to avoid this potential problem. Since we modify the
transformations dictionary structure while iterating over it, we may
fail to iterate over all entries.

Explanation: "Iterating views while adding or deleting entries in the
dictionary may raise a `RuntimeError` or fail to iterate over all
entries"

https://docs.python.org/3/library/stdtypes.html#dictionary-view-objects

This is my first time contributing to Pint, so please let me know if
something needs to be improved / changed.

Co-authored-by: Damien Cupif <dcupif@kpler.com>

38249 of 42915 relevant lines covered (89.13%)

5.22 hits per line

Jobs
ID Job ID Ran Files Coverage
4 1487.4 (PKGS="python=3.8") 28 Dec 2019 03:02AM UTC 0
74.75
Travis Job 1487.4
5 1487.5 (PKGS="python=3.6 uncertainties=3.0") 28 Dec 2019 03:02AM UTC 0
91.99
Travis Job 1487.5
6 1487.6 (PKGS="python=3.7 uncertainties=3.0") 28 Dec 2019 03:10AM UTC 0
91.99
Travis Job 1487.6
9 1487.9 (PKGS="python=3.8 numpy=1.17 matplotlib") 28 Dec 2019 03:05AM UTC 0
90.25
Travis Job 1487.9
10 1487.10 (PKGS="python=3.6 numpy=1.14 uncertainties=3.0") 28 Dec 2019 03:04AM UTC 0
88.64
Travis Job 1487.10
11 1487.11 (PKGS="python=3.7 numpy=1.14 uncertainties=3.0") 28 Dec 2019 03:06AM UTC 0
88.6
Travis Job 1487.11
Source Files on build 1487
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #1487
  • 3739dd07 on github
  • Prev Build on master (#1482)
  • Next Build on master (#1489)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc