georust / geo / 1786

86%

push

travis-ci

Merge #402

402: Simplify indices r=urschrei a=urschrei

This PR adds a new trait to the `simplify` and `simplifyVW` modules: `SimplifyIdx` and `SimplifyVwIdx`.
Both traits do the same thing: they run the respective simplification algorithm, but return the _indices_ of the simplified `LineString`, instead of the simplified geometry. This is mostly in response to ongoing requests from FFI consumers: because their use-cases don't necessarily map onto the Simple Features geometry model, returning geometries is less useful than returning indices, which can be used as mask values / input into native filter functions.

The only current drawback to these new traits is that because they return `Vec<usize>`, they're only implemented for `LineString`. If there's a more flexible way to do it, I'd love to extend it to some other geometries.

This change introduces some additional indirection for the RDP implementation, but `cargo bench` hasn't shown a perf hit…

Co-authored-by: Stephan Hügel <shugel@tcd.ie>
Co-authored-by: Stephan Hügel <urschrei@gmail.com>

26 of 26 new or added lines in 2 files covered. (100.0%)

9462 of 10596 relevant lines covered (89.3%)

3.79 hits per line