1417
91%

Ran 20 Dec 2019 01:54AM UTC

Jobs 14

Files 170

Run time 4min

Badge

Embed ▾

pending completion

Build # 1417

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Merge #940

940: Reimplement cumulative product NumPy functions r=hgrecco a=jthielen

This PR resolves two issues from #905 that were identified in #939:

First, `convert_arg` in `numpy_func.py` presumes `pre_calc_units` is a `Unit` or `None`, but there are instances where it was passed a string by way of `inputs_units` in `implement_func`. Now, any `inputs_units` as a string are converted to a `Unit` before being passed to `convert_to_consistent_units`.

Second, the cumulative product functions were using `implement_func` with `input_units` set to something other than `None`, which was incorrect, since these functions have arguments that should not have units (namely `axis`). These functions have been reimplemented accordingly.

- [x] Closes #939 
- [x] Executed ``black -t py36 . && isort -rc . && flake8`` with no errors
- [x] The change is fully covered by automated unit tests
- ~~Documented in docs/ as appropriate~~
- ~~Added an entry to the CHANGES file~~ (fixup to previous change: #905)


Co-authored-by: Jon Thielen <github@jont.cc>

Run Details

31316 of 36571 relevant lines covered (85.63%)

11.06 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	1417.1 (PKGS="python=3.7 flake8 black isort")	20 Dec 2019 01:54AM UTC		Travis Job 1417.1
2	1417.2 (PKGS="python=3.6")	20 Dec 2019 01:54AM UTC	76.36	Travis Job 1417.2
3	1417.3 (PKGS="python=3.7")	20 Dec 2019 01:54AM UTC	76.28	Travis Job 1417.3
4	1417.4 (PKGS="python=3.8")	20 Dec 2019 01:54AM UTC	76.71	Travis Job 1417.4
5	1417.5 (PKGS="python=3.6 uncertainties=3.0")	20 Dec 2019 01:55AM UTC	89.29	Travis Job 1417.5
6	1417.6 (PKGS="python=3.7 uncertainties=3.0")	20 Dec 2019 01:56AM UTC	89.37	Travis Job 1417.6
7	1417.7 (PKGS="python=3.6 numpy=1.14")	20 Dec 2019 01:56AM UTC	85.35	Travis Job 1417.7
8	1417.8 (PKGS="python=3.7 numpy=1.14")	20 Dec 2019 01:56AM UTC	85.26	Travis Job 1417.8
9	1417.9 (PKGS="python=3.8 numpy=1.17")	20 Dec 2019 01:56AM UTC	87.59	Travis Job 1417.9
10	1417.10 (PKGS="python=3.6 numpy=1.14 uncertainties=3.0")	20 Dec 2019 01:57AM UTC	87.26	Travis Job 1417.10
11	1417.11 (PKGS="python=3.7 numpy=1.14 uncertainties=3.0")	20 Dec 2019 01:58AM UTC	87.26	Travis Job 1417.11
12	1417.12 (PKGS="python=3.6 numpy uncertainties")	20 Dec 2019 01:58AM UTC	89.37	Travis Job 1417.12
13	1417.13 (PKGS="python=3.7 numpy uncertainties")	20 Dec 2019 01:58AM UTC	89.29	Travis Job 1417.13
14	1417.14 (PKGS="python=3.8 numpy uncertainties")	20 Dec 2019 01:58AM UTC	89.55	Travis Job 1417.14

Source Files on build 1417

Detailed source file information is not available for this build.

hgrecco / pint / 1417
91%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1417

hgrecco / pint / 1417 91%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1417

hgrecco / pint / 1417
91%

README BADGES
x