1416
92%
master: 91%

Ran 20 Dec 2019 01:48AM UTC

Jobs 13

Files 204

Run time 4min

Badge

Embed ▾

pending completion

Build # 1416

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Merge #940

940: Reimplement cumulative product NumPy functions r=hgrecco a=jthielen

This PR resolves two issues from #905 that were identified in #939:

First, `convert_arg` in `numpy_func.py` presumes `pre_calc_units` is a `Unit` or `None`, but there are instances where it was passed a string by way of `inputs_units` in `implement_func`. Now, any `inputs_units` as a string are converted to a `Unit` before being passed to `convert_to_consistent_units`.

Second, the cumulative product functions were using `implement_func` with `input_units` set to something other than `None`, which was incorrect, since these functions have arguments that should not have units (namely `axis`). These functions have been reimplemented accordingly.

- [x] Closes #939 
- [x] Executed ``black -t py36 . && isort -rc . && flake8`` with no errors
- [x] The change is fully covered by automated unit tests
- ~~Documented in docs/ as appropriate~~
- ~~Added an entry to the CHANGES file~~ (fixup to previous change: #905)


Co-authored-by: Jon Thielen <github@jont.cc>

Run Details

37792 of 43801 relevant lines covered (86.28%)

11.08 hits per line

Jobs

ID	Job ID	Ran	Coverage
2	1416.2 (PKGS="python=3.6")	20 Dec 2019 01:48AM UTC	76.36	Travis Job 1416.2
3	1416.3 (PKGS="python=3.7")	20 Dec 2019 01:48AM UTC	76.36	Travis Job 1416.3
4	1416.4 (PKGS="python=3.8")	20 Dec 2019 01:48AM UTC	76.63	Travis Job 1416.4
5	1416.5 (PKGS="python=3.6 uncertainties=3.0")	20 Dec 2019 01:49AM UTC	89.37	Travis Job 1416.5
6	1416.6 (PKGS="python=3.7 uncertainties=3.0")	20 Dec 2019 01:50AM UTC	89.37	Travis Job 1416.6
7	1416.7 (PKGS="python=3.6 numpy=1.14")	20 Dec 2019 01:50AM UTC	85.35	Travis Job 1416.7
8	1416.8 (PKGS="python=3.7 numpy=1.14")	20 Dec 2019 01:50AM UTC	85.35	Travis Job 1416.8
9	1416.9 (PKGS="python=3.8 numpy=1.17")	20 Dec 2019 01:50AM UTC	87.67	Travis Job 1416.9
10	1416.10 (PKGS="python=3.6 numpy=1.14 uncertainties=3.0")	20 Dec 2019 01:51AM UTC	87.26	Travis Job 1416.10
11	1416.11 (PKGS="python=3.7 numpy=1.14 uncertainties=3.0")	20 Dec 2019 01:52AM UTC	87.26	Travis Job 1416.11
12	1416.12 (PKGS="python=3.6 numpy uncertainties")	20 Dec 2019 01:52AM UTC	89.37	Travis Job 1416.12
13	1416.13 (PKGS="python=3.7 numpy uncertainties")	20 Dec 2019 01:52AM UTC	89.37	Travis Job 1416.13
14	1416.14 (PKGS="python=3.8 numpy uncertainties")	20 Dec 2019 01:52AM UTC	89.47	Travis Job 1416.14

Source Files on build 1416

Detailed source file information is not available for this build.

hgrecco / pint / 1416
92%
master: 91%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1416

hgrecco / pint / 1416 92% master: 91%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1416

hgrecco / pint / 1416
92%
master: 91%

README BADGES
x