openconfig / ygot / 1657

89%

push

travis-ci

Split genState into smaller generators. (#338)

* Split genState into smaller generators.

Currently, genState contains all the internal state variables and
generation functions for both Go and proto, making the code more
confusing than necessary and changes to the code seemingly more
precarious due to the lack of clear separation between Go and proto
generation. This is a problem for both the reader of the code as well as
maintainers.

To help with this, genState is split into protoGenState, goGenState,
enumGenState, and schemaTree. schemaTree embeds ctree.Tree,
allowing resolveLeafrefTarget to be attached to it, acting as a helper for
generation, and enumGenState contains functionality and internal state
used for generating enum names. These two are language independent.
protoGenState and goGenState then contains the language-specific
generation functionalities.

The generation methods are partitioned either into one of these new
smaller generators, or became independent of generation state and lost
their receivers, making each of the generators easier to understand.

166 of 166 new or added lines in 7 files covered. (100.0%)

28473 of 31464 relevant lines covered (90.49%)

1123.87 hits per line