optimizely / javascript-sdk / 1177

78%

push

travis-ci

fix: Correct decision notification payload type for getVariation feature test decision (#375)

Summary:

In createProjectConfig, we attempt to create an object experimentFeatureMap whose keys are experiment IDs, and whose values are arrays of feature IDs. We loop over each experiment ID in each feature flag's experimentIds, and update experimentFeatureMap accordingly. The problem occurs when one of these experiments is in a group (had a groupId property). The inner loop breaks out by returning false (this early iteration exit by returning false is a feature of lodash forEach). Then, any remaining experiment IDs are wrongfully excluded from experimentFeatureMap. For any of these skipped feature experiment IDs, the isFeatureExperiment function will wrongly return false, leading to an incorrect decision notification payload. With this change, the loop always runs over all experiment IDs of each feature. The previous behavior of only assigning feature.groupId once is maintained.

Test plan:
New unit tests for isFeatureExperiment function of project config module

Issues:
https://optimizely.atlassian.net/browse/OASIS-5759

3120 of 3425 branches covered (91.09%)

Branch coverage included in aggregate %.

33120 of 33740 relevant lines covered (98.16%)

127.47 hits per line