• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

optimizely / javascript-sdk / 1177
78%

Build:
DEFAULT BRANCH: master
Ran 17 Dec 2019 05:40PM UTC
Jobs 6
Files 295
Run time 4min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
1177

push

travis-ci

web-flow
fix: Correct decision notification payload type for getVariation feature test decision (#375)

Summary:

In createProjectConfig, we attempt to create an object experimentFeatureMap whose keys are experiment IDs, and whose values are arrays of feature IDs. We loop over each experiment ID in each feature flag's experimentIds, and update experimentFeatureMap accordingly. The problem occurs when one of these experiments is in a group (had a groupId property). The inner loop breaks out by returning false (this early iteration exit by returning false is a feature of lodash forEach). Then, any remaining experiment IDs are wrongfully excluded from experimentFeatureMap. For any of these skipped feature experiment IDs, the isFeatureExperiment function will wrongly return false, leading to an incorrect decision notification payload. With this change, the loop always runs over all experiment IDs of each feature. The previous behavior of only assigning feature.groupId once is maintained.

Test plan:
New unit tests for isFeatureExperiment function of project config module

Issues:
https://optimizely.atlassian.net/browse/OASIS-5759

3120 of 3425 branches covered (91.09%)

Branch coverage included in aggregate %.

33120 of 33740 relevant lines covered (98.16%)

127.47 hits per line

Jobs
ID Job ID Ran Files Coverage
3 1177.3 17 Dec 2019 05:40PM UTC 0
97.51
Travis Job 1177.3
4 1177.4 17 Dec 2019 05:44PM UTC 0
97.51
Travis Job 1177.4
5 1177.5 17 Dec 2019 05:42PM UTC 0
97.51
Travis Job 1177.5
6 1177.6 17 Dec 2019 05:42PM UTC 0
97.51
Travis Job 1177.6
7 1177.7 17 Dec 2019 05:44PM UTC 0
97.51
Travis Job 1177.7
8 1177.8 17 Dec 2019 05:42PM UTC 0
97.51
Travis Job 1177.8
Source Files on build 1177
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #1177
  • 8b2177b2 on github
  • Prev Build on master (#1161)
  • Next Build on master (#1179)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2025 Coveralls, Inc